Skip to content

missing return value in sample function calls (I think) #1088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 16, 2016
Merged

missing return value in sample function calls (I think) #1088

merged 2 commits into from
Nov 16, 2016

Conversation

vnoel
Copy link
Contributor

@vnoel vnoel commented Nov 7, 2016

sorry if I messed up, I'm not a github master

@jhamman
Copy link
Member

jhamman commented Nov 7, 2016

I'm fine with this change but it isn't entirely necessary since these examples are really just hypotheticals.

@vnoel
Copy link
Contributor Author

vnoel commented Nov 7, 2016

I was briefly confused by the examples as at first they seemed to me to do nothing -- read data and forget it. This change prevents any similar confusion :-)

@shoyer shoyer merged commit 6c90583 into pydata:master Nov 16, 2016
@shoyer
Copy link
Member

shoyer commented Nov 16, 2016

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vnoel @jhamman @shoyer